Conversation
Signed-off-by: gokulprasanth-ni <131153319+gokulprasanth-ni@users.noreply.github.com>
Signed-off-by: gokulprasanth-ni <131153319+gokulprasanth-ni@users.noreply.github.com>
Signed-off-by: gokulprasanth-ni <131153319+gokulprasanth-ni@users.noreply.github.com>
Signed-off-by: gokulprasanth-ni <131153319+gokulprasanth-ni@users.noreply.github.com>
Signed-off-by: gokulprasanth-ni <131153319+gokulprasanth-ni@users.noreply.github.com>
Signed-off-by: gokulprasanth-ni <131153319+gokulprasanth-ni@users.noreply.github.com>
| @@ -0,0 +1,48 @@ | |||
| import { fileURLToPath } from 'url'; | |||
There was a problem hiding this comment.
These are too many changes in one shot. One thing to note is that packages do not need to migrate to "type": "module" in order to adopt eslint v9. Those can be decoupled, see the discussion here: ni/javascript-styleguide#170 (comment)
If the changes are minor outside the nimble repo then it may be fine but we should not switch the packages in nimble.
There was a problem hiding this comment.
@gokulprasanth-ni the nimble repo is sufficiently unusual that we'll handle the upgrade, but thanks for the initial draft
There was a problem hiding this comment.
After sleeping on it, I think a plan to do the update in smaller parts would be:
- One change that updates the eslint configs without changing the package types. Some configs use esm format and some use commonjs format. Also disable prettier temporarily by updating the
lintandlint-concurrentscripts inpackage.jsonto not call prettier temporarily and only call eslint. Hopefully that minimizes the number of changes needed in the first PR. - A follow up PR where prettier is enabled and it's formatting changes are applied.
The goal being to not force nimble to switch to type module yet and to split prettier formatting changes to a separate standalone PR
There was a problem hiding this comment.
Also incase it is a consideration, we should be updating the AzDo pipelines first
There was a problem hiding this comment.
Yeah thanks for the suggestion Milan. I will plan to create PRs as suggested.
gokulprasanth-ni
changed the title
2 participants
Pull Request
🤨 Rationale
👩💻 Implementation
🧪 Testing
✅ Checklist